whonixcheck workaround can be removed in qubes-whonix 10

phabricator-migrator · February 19, 2024, 5:50pm

Information

ID: 248
PHID: PHID-TASK-q43jmvjpy3n5qik432ki
Author: Patrick
Status at Migration Time: resolved
Priority at Migration Time: Normal

Description

https://github.com/QubesOS/qubes-linux-template-builder/blob/master/scripts_debian/wheezy%2Bwhonix/02_install_groups_packages_installed.sh#L248

    # Prevent whonixcheck error
    echo 'WHONIXCHECK_NO_EXIT_ON_UNSUPPORTED_VIRTUALIZER="1"' >> "${INSTALLDIR}/etc/whonix.d/30_whonixcheck_default"

Can be removed.

That should be fixed in whonixcheck that comes with Whonix 10. I think we discussed/fixed this elsewhere already but not sure. If you get this updated file for testing, it should work out of the box:
https://github.com/Whonix/whonixcheck/blob/master/usr/lib/whonixcheck/check_virtualizer

As a side note, generally, when having the “.d” mechanism (Configuration Files - Kicksecure) it’s best not to touch the original file but to ship one that overrules the default setting. (Higher number named file.)

Comments

Patrick

2015-06-11 03:09:28 UTC

nrgaway

2015-06-11 10:55:25 UTC

Patrick

2015-06-11 11:24:29 UTC

! In T248#5442, @nrgaway wrote:
Its now in etc/whonix.d/40_qubes:WHONIXCHECK_NO_EXIT_ON_UNSUPPORTED_VIRTUALIZER="1"
since I was still getting those errors in Whonix 10.

That’s better.

You saying I should not have? Guess we could try removing it for Whonix 11?

The right thing is to fix it upstream in #whonixcheck, no? It should be fixed upstream in #whonixcheck already. I remember discussing this with WhonixQubes and fixing this. (check_virtualizer script)

For a quick test:

no rebuild required

(Temporarily) remove the WHONIXCHECK_NO_EXIT_ON_UNSUPPORTED_VIRTUALIZER setting.

Run: whonixcheck --function check_virtualizer | Expected result: nothing

Run: whonixcheck --verbose --function check_virtualizer | Expected result: supported virtualizer

Otherwise it should be fixed upstream in #whonixcheck for #qubes-whonix_12.

Patrick

2015-08-16 02:07:34 UTC