whonix-setup-wizard start bug if /usr/bin/kcmshell4 does not exist

[phabricator-migrator]

Information

ID: 156
PHID: PHID-TASK-gzbz3l2a2g5tszcnwrbh
Author: Patrick
Status at Migration Time: resolved
Priority at Migration Time: Normal

Description

I think here is currently a bug:

    if not os.path.exists('/usr/bin/kcmshell4'):
        sys.exit(0)

Because whole whonix-setup-wizard will refuse to work just because /usr/bin/kcmshell4 does not exist. While the real intent is just to skip running locale_settings.

Comments

---

Patrick

2015-02-10 03:50:26 UTC

Done:
https://github.com/Whonix/whonix-setup-wizard/commit/ec04e296843ff09dcdb890474963bc161ee0efd3

Can you review and merge please, @troubadour?

---

troubadour

2015-02-10 20:50:43 UTC

There was an issue in if kcmshell == "":. Should be if kcmshell == None: in python.

Reorganized it a bit to add a warning finish page if kcmshell4 is not found (no print).
new page in locale_settings if kcmshell4 not found · troubadoour/whonix-setup-wizard@730f693 · GitHub

The distutils.spawn was a good find. The less we use os, the better.

---

troubadour

2015-02-10 21:13:15 UTC

Forgot to push the updated translations.
translations for new pages · troubadoour/whonix-setup-wizard@161f730 · GitHub

---

Patrick

2015-02-11 01:22:51 UTC

Merged.

I think there is a problem. It doesn’t exit anymore without showing a message.

Background: we supposed to run it for default builds, for KDE users. For custom builds using other desktops such as GNOME, we wanted to just skip it and exit. Now when whonix-setup-wizard locale_settings is being run, it would interrupt the boot process (we wanted to start it using xinit) without working for these type of users. Not a good idea?

---

troubadour

2015-02-11 15:36:08 UTC

Some misunderstanding here. Have put the check for kcmshell4 in the main function, so that it exits without starting the wizard if not found.
kcmshell4 check in main() · troubadoour/whonix-setup-wizard@02da9d4 · GitHub

---

Patrick

2015-02-11 15:55:50 UTC

                        command = '/usr/bin/kcmshell4 language'

vs

                            command = '%s language' % (kcmshell)

The latter is more correct. Because it does not hard code the path to /usr/bin. Let’s say the path changed to /usr/sbin (unlikely in this case, but generally), then we’re better off using the latter.

The latter works for any default path, that can (probably?) be set using the PATH environment variable. Some people like to add wrappers to /usr/local/bin, that are always preferred over /usr/bin. Or manually compile and install to /usr/local/bin. Not a big deal, but more correct and a future bug report we can prevent.

---

locale settings are designed for KDE desktop. → Really? I’d rather say locale settings are currently only implemented for KDE desktop.

---

troubadour

2015-02-11 16:38:59 UTC

Yes to both. For the first one, just have to add the line kcmshell = distutils.spawn.find_executable("kcmshell4") before the commands. Wiil do right away.

---

troubadour

2015-02-11 16:48:23 UTC

Done.

---

Patrick

2015-02-11 17:46:37 UTC

Alright.