Not that I know, but no need since the dependency could be added to the host package whonix-host-xfce-kvm-freedom
which only gets installed on Whonix Host Xfce KVM.
Should I add it now or when a full configuration is added?
Dunno. I don’t know what would speak about doing it now.
add
virt-xml "Whonix-Workstation" --add-device --filesystem source=/mnt/shared,target=shared,type=mount,accessmode=mapped`
below
https://github.com/Whonix/whonix-libvirt/blob/master/usr/lib/whonix-libvirt/install#L69-L78
?
And above, add
mkdir --parents /mnt/shared
chmod 777 /mnt/shared
?
Then this is fully implemented? No need for ConditionVirtualization=false
or any other changes?
OK these two commands need to precede the virt-xml one or else it fails becuase the folder doesn;t exist
No need for service conditions now after this. incron can just go into the host package you mentioned.
Ok. Could you add too please?
virt-xml “Whonix-Workstation” --add-device --filesystem source=/mnt/shared,target=shared,type=mount,accessmode=mapped` || true
Does it need -c qemu:///system
?
OK Does it need to be in a if-then block?
No this is a dedicated tool that doesn’t use this notation
No, since these commands are idempotent.
Done
This commit does not show up in git master branch.
Commits · Kicksecure/libvirt-dist · GitHub
I also don’t see a new branch.
It also does not show up in https://github.com/Whonix/whonix-libvirt/blob/master/usr/lib/whonix-libvirt/install
git fetch
followed by git show
does not show commit 25649bd7f16f8030a5c9d812146b53711c5e330f
either.
Really strange.
Did you use “directly commit to git” using github web? I have no idea how to use that or how to make use of such commits (without manual copy/paste which would be besides the point and loose authorship and commit messages).
I’m using the web interface right now and it seems to have messed things upat your end? I was commiting the patch to the master branch
Never mind I missed Add shared folder by HulaHoopWhonix · Pull Request #85 · Kicksecure/libvirt-dist · GitHub which will work as usual.
Merged.
Do you think Whonix GW should have it added as well? Or leaveit on per user basis?
I imagine this could be part of a usability tool on the GW where users want to backup/restore onion keys on demand.
Yes. Doesn’t hurt.
Is /mnt/shared
is too generic as name and GW would have to use a different folder?
Yes.
It’s probably better for security. What name do you recommend?
/mnt/gateway-shared
/mnt/workstation-shared