sdwdate-gui tray icon invisible in Debian stretch

phabricator-migrator · February 19, 2024, 5:44pm

Information

ID: 598
PHID: PHID-TASK-cmvvljmfyhic5dxa7lsj
Author: Patrick
Status at Migration Time: resolved
Priority at Migration Time: Normal

Description

It’s tray icon is invisible inside #debian_stretch . It’s fully functional still, but invisible.

Comments

Patrick

2017-01-15 06:03:33 UTC

joysn1980

2017-02-07 08:18:20 UTC

Patrick

2017-02-07 17:20:19 UTC

Patrick

2017-02-07 17:58:10 UTC

joysn1980

2017-02-08 06:31:01 UTC

https://github.com/joysn/sdwdate-gui/tree/master/usr/lib/python3.4/dist-packages/sdwdate_gui

Few things

I am not sure what changes are needed to make sure that we do
sudo apt-get install python3-pyqt5
which is necessary for this change to work. Let me know if any files needs to be modified for that.

The original sdwdate_gui.py was located at
/usr/lib/python2.7/dist-packages/sdwdate_gui/sdwdate_gui.py

I created new directory for python3.4
/usr/lib/python3.4/dist-packages/sdwdate_gui/sdwdate_gui.py

In Debian Stretch is works seamlessly, but in Debian Jessie, we see some extra errors [but does not change any functionalities]
libGL error: pci id for fd 10: 80ee:beef, driver (null)
libGL error: core dri or dri2 extension not found
libGL error: failed to load driver: vboxvideo
I googled and find the issue to be VM related but no fix as such apart from start using newer versions.

I am not sure how do I display the actual changes since this commit is a “new file”. Do you want me to make another commit, which is on top of existing sdwdate_gui.py so that you can “view” the changes? Any other way?

Patrick

2017-02-08 14:55:35 UTC

These packaging related changes are done in git master. (And can be seen in the git history.)

I deleted the python2.7 version to make the diff easier to read and since we no longer need the python2.7 version. Moved from python3.4 files to python3 to fix a lintian warning. I am not too sure about that, perhaps it would have been better to move to python3.5, but it works. On Debian /usr/bin/python3 is a symlink to python3.5.

Never mind about jessie. As long as it works on stretch we are well set for the future.

It’s alright now in git master. By deleting the 2.7 version in a separate branch and then using git diff -C the diff was very easy to review.

I broke https://github.com/Whonix/sdwdate-gui/blob/master/usr/lib/sdwdate-gui/show_message (by changing to python3). Could you please port it to python3 / newer Qt also?

joysn1980

2017-02-08 15:11:15 UTC

Patrick

2017-02-08 15:18:36 UTC

joysn1980

2017-02-08 16:27:22 UTC

Patrick

2017-02-08 22:11:16 UTC

joysn1980

2017-02-09 05:25:20 UTC

joysn1980

2017-02-09 09:54:23 UTC

Yes it is indeed by design.
Some comments in the code

        ## When restarted from sdwdate-gui, allow sufficient time between
        ## status changes. See related comment in sdwdate-gui.

        ## When the file is quickly rewritten by another operation, reading
        ## would fail. TOCTOU

        ## QFileSystemWatcher may emit the fileChanged signal twice
        ## or three times, randomly. Filter to allow enough time
        ## between kill and restart popup in show_message(), and
        ## prevent os.kill to raise an error and leave a gui open.

So, I think if this needs a fix, this probably needs a re-design. A new ticket is desirable for that.

Patrick

2017-02-09 12:50:23 UTC

! In T598#12098, @joysn1980 wrote:
I see the same issue (repeated right click , restart ) is present even in the older version. Can you verify that once?

Works for me in Whonix 13. Right click does not lock up.
Yes it is indeed by design.
Some comments in the code
        ## When the file is quickly rewritten by another operation, reading
        ## would fail. TOCTOU
        try:
            with open(self.status_path, 'rb') as f:
                status = pickle.load(f)
        except:
            return
I do not think this is related. Also possibly nothing can be done about it. It’s about showing status messages. When one status is written and then sdwdate quickly progressing in the next moment and another status written. In these situation the one status that did not finish writing to disk is discarded and that later status that was written gets used.
    ## When restarted from sdwdate-gui, allow sufficient time between
    ## status changes. See related comment in sdwdate-gui.
Same as below.
        ## QFileSystemWatcher may emit the fileChanged signal twice
        ## or three times, randomly. 
QFileSystemWatcher does not seem random. That would be a python bug. This was a previous issue which I might have quite some time ago here:
fixed stale status bug and better error handling · Kicksecure/sdwdate-gui@0046d21 · GitHub

During that time ./usr/share/sdwdate-gui/unit-test/fuzzer was created. It creates tons of messages in a very short time to check if sdwdate-gui has an issue with that. sdwdate-gui then supported super fast file changes and never messed up.
        ## QFileSystemWatcher may emit the fileChanged signal twice
        ## or three times, randomly. Filter to allow enough time
        ## between kill and restart popup in show_message(), and
        ## prevent os.kill to raise an error and leave a gui open.
        if self.message != self.previous_message:
            self.setToolTip('%s\n%s' %(self.title, self.stripped_message))
            self.update.update_tip.emit()
        self.previous_message = self.message
That comment may be outdated, but that code may be good to keep. If sdwdate gets or some other case it could indeed happen that it issues the same message twice. Protecting from duplicate passive popups seems useful.

So, I think if this needs a fix, this probably needs a re-design. A new ticket is desirable for that.

Created T626 for that.

Patrick

2017-02-09 18:13:55 UTC

Patrick

2017-02-10 01:16:26 UTC

joysn1980

2017-02-13 12:26:58 UTC

Patrick

2017-02-14 14:20:49 UTC

joysn1980

2017-02-15 13:26:23 UTC

Just an update.

By default each system tray icon has “visibility” value “Auto”. Meaning, we have to press “Up Arrow Key” in the system tray icon to see the icon.
{F169957}

In case, we always want the sdwdate to be always shown then we need to modify
/home/user/.config/plasma-org.kde.plasma.desktop-appletsrc
file to add the below line at the end
shownItems=\\0
It should be in the General Containments. The updated section will look like below
[Containments][7][General]
extraItems=org.kde.plasma.notifications,org.kde.plasma.battery,org.kde.plasma.volume,org.kde.plasma.mediacontroller,org.kde.plasma.devicenotifier,org.kde.plasma.clipboard
knownItems=org.kde.plasma.notifications,org.kde.plasma.battery,org.kde.plasma.volume,org.kde.plasma.mediacontroller,org.kde.plasma.devicenotifier,org.kde.plasma.clipboard
shownItems=\\0
Through UI it is easy, but the above can be updated using script. I am not sure what changes are to be done for this, so thought of posting this here.

Patrick

2017-02-15 20:16:05 UTC

Thanks for reporting!

Making edits in user’s /home kde dirs directly isn’t a clean solution. Easily breaks or breaks unrelated things or interferes with user settings.

The clean solution is dropping a kde configuration snippet. Here is an example, package https://github.com/Whonix/kde-dolphin-menubar-enable… Essentially two files:

config file: https://github.com/Whonix/kde-dolphin-menubar-enable/blob/master/usr/share/kde-dolphin-menubar-enable/share/config/dolphinrc

environment variable: https://github.com/Whonix/kde-dolphin-menubar-enable/blob/master/etc/X11/Xsession.d/50kde-dolphin-menubar-enable

The other files are just for packaging purposes.

That worked in Debian jessie based Whonix. Currently broken in Debian stretch based Whonix. Apparently the KDEDIRS variable was abolished and hopefully replaced by something else. Still TODO to figure that out and fix.

A similar solution for “always show all tray icons” or “always show sdwate-gui” might have to be added.

Patrick

2017-02-15 20:58:28 UTC

Patrick

2017-02-19 23:07:08 UTC