rerunning 'make get-sources' breaks Qubes Builder

[phabricator-migrator]

Information

ID: 415
PHID: PHID-TASK-y6zleeqwgh4juuf2iydh
Author: Patrick
Status at Migration Time: resolved
Priority at Migration Time: High

Description

When rerunning make get-sources, it breaks for the Whonix folder (https://github.com/Whonix/Whonix).

--> Downloading additional sources for Whonix...
+ make --quiet -C qubes-src/Whonix get-sources

I could implement a dummy in #makefile-generic-packages (genmkfile). Easy.

Do you think there is a more appropriate solution? And anything else that should be implemented?

(There already is an empty Makefile.builder [https://github.com/Whonix/Whonix/blob/master/Makefile.builder].)

Comments

---

Patrick

2015-10-11 11:50:44 UTC

Workaround for now.

• allow running arbitrary make targets · Kicksecure/genmkfile@a3d1283 · GitHub
• https://github.com/Whonix/Whonix/commit/4edfb4fb1847a9cf6862d2df042d8a21e8b45d89

---

Patrick

2015-10-14 08:31:25 UTC

@marmarek what do you think?

---

marmarek

2015-10-14 18:34:13 UTC

qubes builder check if get-sources and verify-sources targets exist
(with make -n get-sources verify-sources), so if genmkfile creates a
wildcard one, it needs to be somehow handled. I think creating empty
(true) get-sources and verify-sources targets is ok. Or maybe you
have some better idea?

---

Patrick

2015-10-14 18:58:15 UTC

That’s fine.

• https://github.com/Whonix/Whonix/commit/06544ed1c32bd2721df00ee7feae940b3b535b51
• fail closed for unknown make targets · Kicksecure/genmkfile@bbe8e98 · GitHub