python-guimessages guimessage.py breaks on default locales settings LANG=POSIX LANG=C

phabricator-migrator · February 19, 2024, 5:44pm

Information

ID: 625
PHID: PHID-TASK-nxg2hdrll7o66fdyihiz
Author: Patrick
Status at Migration Time: resolved
Priority at Migration Time: Normal

Description

This recently happened to me due to an update-locales / locales issue.

https://github.com/Whonix/python-guimessages/blob/master/usr/share/pyshared/guimessages/guimessage.py has a bug.

How to reproduce:

sudo LANG=POSIX usr/bin/sdwdate

sdwdate started. PID 922
Traceback (most recent call last):
  File "usr/bin/sdwdate", line 548, in <module>
    sdwdate = Sdwdate()
  File "usr/bin/sdwdate", line 108, in __init__
    translation = _translations(translations_path, 'sdwdate')
  File "/usr/lib/python2.7/dist-packages/guimessages/translations.py", line 17, in __init__
    language = locale.getdefaultlocale()[0].split('_')[0]
AttributeError: 'NoneType' object has no attribute 'split'

Also broken with another legitimate LANG value of C.

sudo LANG=C usr/bin/sdwdate

In these cases it should rather fall back to some sane default, i.e. en/us, i.e. as if running sudo LANG=en_US.UTF-8 usr/bin/sdwdate.

Comments

joysn1980

2017-02-08 15:36:23 UTC

Patrick

2017-02-08 20:46:03 UTC

That one is fixed.

But guimessage.py is still not very robust.
sudo LANG=de_DE usr/bin/sdwdate
sdwdate started. PID 17548
Tor socks host: 127.0.0.1  Tor socks port: 9050
Prerequisite check: ok.
Fetching remote times, start Wed Feb 08 20:27:23 UTC 2017 (unixtime 1486585643.73)
Traceback (most recent call last):
  File "usr/bin/sdwdate", line 559, in <module>
    icon, status = sdwdate.sdwdate_loop()
  File "usr/bin/sdwdate", line 327, in sdwdate_loop
    time_sanity_check = self.time_sanity_check(current_unixtime)
  File "usr/bin/sdwdate", line 171, in time_sanity_check
    self.message = (self._('tsc_1') + status + self._('tsc_2') + time_one)
  File "/usr/lib/python2.7/dist-packages/guimessages/translations.py", line 36, in gettext
    return self.language.get(key, None)
AttributeError: 'str' object has no attribute 'get'
That results in a chain reaction in Whonix 14 btw. sdwdate does not start, therefore not succeed, therefore the firewall won’t allow full network access, therefore networking will be broken.

Do you think you could make this more robust? I.e. in these cases rather than failing default back to en?

Patrick

2017-02-08 21:56:43 UTC

joysn1980

2017-02-09 05:54:08 UTC