port Whonix's init.d scripts to systemd

[phabricator-migrator]

Information

ID: 106
PHID: PHID-TASK-uqxkdxdo2btly54y5m2j
Author: Patrick
Status at Migration Time: resolved
Priority at Migration Time: High

Description

(To find them…)

find . -type f | grep init.d

Comments on roughly guessed difficulty.

• easy: ./packages/whonixcheck/etc/init.d/whonixcheck
• easy: ./packages/ksm/etc/init.d/ksm (patches welcome) → https://packages.debian.org/sid/ksmtuned
• hard: ./packages/sdwdate/etc/init.d/sdwdate
• hard: timesync
• medium: ./packages/swap-file-creator/etc/init.d/swap-file-creator
• easy: ./packages/msgcollector/etc/init.d/msgcollector
• medium: ./packages/vbox-disable-timesync/etc/init.d/vbox-disable-timesync (not ported to systemd, but made compatible, see below)
• medium: ./anon-ws-disable-stacked-tor/etc/init.d/tor.anondist → T303
• easy: ./packages/timesanitycheck/etc/init.d/timesanitycheck
• harder: ./packages/whonix-initializer/etc/init.d/whonix-initializer (done)
• easy: ./packages/bootclockrandomization/etc/init.d/bootclockrandomization
• unknown: GitHub - troubadoour/control-port-filter-python in Whonix 10. (See also: https://git-tails.immerda.ch/tails/tree/config/chroot_local-includes/lib/systemd/system/tor-controlport-filter.service?h=feature/jessie): T274
• hard: rads: T57

Forum thread:

Whonix Forum

Comments

---

Patrick

2015-04-02 14:56:32 UTC

refactoring for future systemd support - https://phabricator.whonix.o… · Kicksecure/swap-file-creator@cba4e22 · GitHub

---

Patrick

2015-04-02 15:40:45 UTC

I won’t do create a systemd unit as replacement for ./packages/ksm/etc/init.d/ksm myself, because the package does not get installed by default and because there is now https://packages.debian.org/sid/ksmtuned. Patches welcome. @HulaHoop

---

Patrick

2015-04-02 16:03:34 UTC

control-port-filter-python - added systemd service:
https://github.com/Whonix/control-port-filter-python/commit/d8e1d5711d2a71a9ab638c03e84a0d9b48d7ae48
Could you review that systemd unit please, @nrgaway?

---

HulaHoop

2015-04-03 22:52:44 UTC

May be helpful for systems configuration. Debian directory structure could be different:

Overview of systemd for RHEL 7 - Red Hat Customer Portal

Paths of the ksm/ksmtuned services on RHEL family:
/usr/lib/systemd/system/ksmtuned.service
/usr/lib/systemd/system/ksm.service

Is adding this for ksmtuned a matter of emulating your commit?

---

Patrick

2015-04-04 11:13:40 UTC

No.

---

nrgaway

2015-04-22 22:30:46 UTC

! In T106#3482, @HulaHoop wrote:
May be helpful for systems configuration. Debian directory structure could be different:

Overview of systemd for RHEL 7 - Red Hat Customer Portal

Paths of the ksm/ksmtuned services on RHEL family:
/usr/lib/systemd/system/ksmtuned.service
/usr/lib/systemd/system/ksm.service

Is adding this for ksmtuned a matter of emulating your commit?

Debian systemd layout is same as fedora.

If you plan on overriding an upstream packages unit files, there are a few options:

1. If you just adding a path or something, add a snippet
2. place overridden unit file in /etc/system/systemd (This is wehre local modifications go). If you are using another name than the original systemd file, add an Alias in the install section

[Install]
WantedBy=multi-user.target
Alias=qubes-network.service

Then you would need to disable and enable the service to take effect.

---

Patrick

2015-04-23 00:11:22 UTC

add a snippet

Can you please elaborate?

---

Patrick

2015-04-26 13:42:23 UTC

@nrgaway?

---

Patrick

2015-04-26 13:46:59 UTC

I am not sure if we should remove old sysvinit scripts from packages once systemd units are available. They don’t conflict. And someone might wish to use/port the package on systems without systemd. Mailed Paul Wise from Debian what the best practice about this is.

---

nrgaway

2015-04-26 13:52:10 UTC

! In T106#3814, @Patrick wrote:
add a snippet

Can you please elaborate?

From [[ Systemd 198 released [LWN.net] | Systemd 198 released [LWN.net] ]]
Configuration of unit files may now be extended via drop-in
files without having to edit/override the unit files
themselves. More specifically, if the administrator wants to
change one value for a service file foobar.service he can
now do so by dropping in a configuration snippet into
/etc/systemd/systemd/foobar.service.d/*.conf. The unit logic
will load all these snippets and apply them on top of the
main unit configuration file, possibly extending or
overriding its settings. Using these drop-in snippets is
generally nicer than the two earlier options for changing
unit files locally: copying the files from
/usr/lib/systemd/system/ to /etc/systemd/system/ and editing
them there; or creating a new file in /etc/systemd/system/
that incorporates the original one via “.include”. Drop-in
snippets into these .d/ directories can be placed in any
directory systemd looks for units in, and the usual
overriding semantics between /usr/lib, /etc and /run apply
for them too.

---

Patrick

2015-04-26 13:55:11 UTC

Great stuff. Needless to say I am a huge fan of drop-in snippets.

---

nrgaway

2015-04-26 13:57:18 UTC

! In T106#3920, @Patrick wrote:
I am not sure if we should remove old sysvinit scripts from packages once systemd units are available. They don’t conflict. And someone might wish to use/port the package on systems without systemd. Mailed Paul Wise from Debian what the best practice about this is.

They can confilct and it is a PITA to debug. You can keep the sysv init scripts in your Debian package but don’t install them. I just went though that with network-manager; was wondering why 2 of them were popping up.

Also in order for a systemd unit file to override the sysv init one, you have to first disable it, then re-enable it and they should be both of the same name or you may need to set an alias

---

Patrick

2015-05-13 14:23:29 UTC

whonixcheck:
https://github.com/Whonix/whonixcheck/commit/c91dc77a1dae49be4635380e330fdfda9cb4ada2

---

Patrick

2015-05-13 14:41:48 UTC

msgcollector:
ported to systemd - https://phabricator.whonix.org/T106 · Kicksecure/msgcollector@ff50e3c · GitHub

---

Patrick

2015-05-13 19:52:20 UTC

bootclockrandomization:
ported to systemd - https://phabricator.whonix.org/T106 · Kicksecure/bootclockrandomization@77d3e62 · GitHub

---

Patrick

2015-05-13 20:26:00 UTC

timesanitycheck:
ported to systemd - https://phabricator.whonix.org/T106 · Kicksecure/timesanitycheck@0364019 · GitHub

---

Patrick

2015-05-13 20:50:24 UTC

swap-file-creator:
ported to systemd - https://phabricator.whonix.org/T106 · Kicksecure/swap-file-creator@a8f58cf · GitHub

---

Patrick

2015-05-14 11:08:38 UTC

vbox-disable-timesync, no port to systemd, because upstream does not provide a systemd unit, diverting it, more robust implementation that is compatible with systemd:
https://github.com/Whonix/vbox-disable-timesync/commit/958086eb0d55e0669492ab16ec15d810a533f597

---

Patrick

2015-05-14 12:39:11 UTC

sdwdate:
ported to systemd - https://phabricator.whonix.org/T106 · Kicksecure/sdwdate@62c32cb · GitHub

timesync:
https://github.com/Whonix/timesync/commit/270a1f3fb397deda261e11e5d4c38e435bbb40d4

sdwdate pidfile is still missing and timesync complains about that. Working on that.

---

Patrick

2015-05-14 23:17:58 UTC

Fixed that:

• write own pid to /var/run/sdwdate/pid · Kicksecure/sdwdate@f1f8d4c · GitHub
• comment · Kicksecure/sdwdate@9b72221 · GitHub

---

Patrick

2015-05-14 23:28:37 UTC

TODO: most should use SuccessExitStatus.

---

Patrick

2015-05-14 23:42:39 UTC

! In T106#4449, @Patrick wrote:
TODO: most should use SuccessExitStatus.

Done:

• systemd unit: added 'SuccessExitStatus = 143' · Kicksecure/sdwdate@2f7960a · GitHub
• https://github.com/Whonix/whonixcheck/commit/7091c9d136f2a7a0051f6f6f94e4a5a86ef1763f

---

Patrick

2015-05-15 00:10:14 UTC

So far everything done here. Created follow up tasks for remaining work.

---

Patrick

2015-05-16 03:55:22 UTC

fix, renamed lib/systemd/system/timesanitycheck to lib/systemd/system/timesanitycheck.service:
fix, renamed lib/systemd/system/timesanitycheck to lib/systemd/system… · Kicksecure/timesanitycheck@fee20a0 · GitHub

---

Patrick

2015-05-17 10:56:47 UTC

fix, lib/systemd/msgcollector.service -> lib/systemd/system/msgcollector.service - https://phabricator.whonix.org/T106:
fix, lib/systemd/msgcollector.service -> lib/systemd/system/msgcollec… · Kicksecure/msgcollector@a708e91 · GitHub

---

Patrick

2015-05-17 11:02:00 UTC

fix:
fix · Kicksecure/msgcollector@8132e8a · GitHub

---

Patrick

2015-05-17 11:45:04 UTC

systemd unit: added 'KillMode = process', because the daemon handles terminating child processes itself - https://phabricator.whonix.org/T106:
systemd unit: added 'KillMode = process', because the daemon handles … · Kicksecure/sdwdate@3a14c5e · GitHub

systemd unit: added 'KillMode = process', because the daemon handles terminating child processes itself - https://phabricator.whonix.org/T106
https://github.com/Whonix/whonixcheck/commit/7cb379710c081a3e14a68b41d1f30c68ca5f1b0e

---

Patrick

2015-05-18 11:51:14 UTC

systemd unit: added 'Before=rads.service' to prevent output by rads mixing up with output by whonix-initializer and to prevent the login manager from starting before whonix-initializer rebooted the system:
systemd unit: added 'Before=rads.service' to prevent output by rads m… · Kicksecure/initializer-dist@80dbb25 · GitHub

---

Patrick

2015-05-18 12:25:52 UTC

when timesync (sdwdate gui plugin) is installed, then the sdwdate.service needs an additional 'Requires = msgcollector.service' - https://phabricator.whonix.org/T106:
https://github.com/Whonix/timesync/commit/e1e88c84c07697825a4aea14ac1c723192a58075

---

Patrick

2015-05-19 20:12:55 UTC

systemd unit: added 'Before=control-port-filter-python.service:
systemd unit: added 'Before=control-port-filter-python.service' · Kicksecure/initializer-dist@ace6738 · GitHub

---

Patrick

2015-05-22 14:21:38 UTC

more work on systemd support - https://phabricator.whonix.org/T106:
https://github.com/Whonix/timesync/commit/0a76d86a8e37ae9691374da69bdef452b6def7cc

---

Patrick

2015-05-23 16:02:54 UTC

systemd unit: added 'StandardOutput=tty' for better look and feel. - https://phabricator.whonix.org/T106
systemd unit: added 'StandardOutput=tty' for better look and feel. - … · Kicksecure/swap-file-creator@f49f572 · GitHub

---

Patrick

2015-05-23 18:07:24 UTC

more work on systemd support - https://phabricator.whonix.org/T106:

• more work on systemd support - https://phabricator.whonix.org/T106 · Kicksecure/sdwdate@0f6e507 · GitHub
• https://github.com/Whonix/timesync/commit/b506ea4186a50bb50ae9b198deefaf2c9a7ca5d8

---

Patrick

2015-05-23 18:40:52 UTC

systemd unit: added 'Before=tor.service' and 'After=swap-file-creator.service' for better look and feel. - https://phabricator.whonix.org/T106:
systemd unit: added 'Before=tor.service' and 'After=swap-file-creator… · Kicksecure/initializer-dist@0c14909 · GitHub

---

Patrick

2015-05-30 13:31:55 UTC

systemd unit: added 'Before=graphical.target' and 'Before=getty.target' - https://phabricator.whonix.org/T106:
systemd unit: added 'Before=graphical.target' and 'Before=getty.targe… · Kicksecure/msgcollector@ab24bd2 · GitHub