port sdwdate, sdwdate-gui to python3

[phabricator-migrator]

Information

ID: 624
PHID: PHID-TASK-3n4osotns5dxuxbcgbwo
Author: Patrick
Status at Migration Time: resolved
Priority at Migration Time: Normal

Description

Comments

---

HulaHoop

2017-02-07 19:20:41 UTC

@joysn1980 You’re awesome.

---

joysn1980

2017-02-08 06:34:23 UTC

Thanks @HulaHoop

⚓ T598 sdwdate-gui tray icon invisible in Debian stretch have the changes.
https://github.com/joysn/sdwdate-gui/tree/master/usr/lib/python3.4/dist-packages/sdwdate_gui

---

joysn1980

2017-02-09 11:07:16 UTC

I am trying to list down the files that needs conversion

/usr/lib/python3/dist-packages/sdwdate_gui/sdwdate_gui.py

/usr/lib/python3/dist-packages/sdwdate/config.py
/usr/lib/python3/dist-packages/sdwdate/proxy_settings.py
/usr/lib/python3/dist-packages/sdwdate/remote_times.py
/usr/lib/python3/dist-packages/sdwdate/timesanitycheck.py

/usr/share/sdwdate/get_time_from_servers_test
/usr/share/sdwdate/unit_test

/usr/bin/sdwdate
/usr/bin/sdwdate-gui

/usr/lib/sdwdate/url_to_unixtime

Are there any other files/path involved here?

I do not think it is correct to take up python-guimessages here in this ticket. It is not related to sdwdate/sdwdate-gui. They should be handled separately.

---

joysn1980

2017-02-09 10:31:40 UTC

Infact, these files itself needs quite a lot of work to convert into python3. It is probably not just changing the shebang.
It requires new modules to be installed, changes in those modules needs to be incorporated too. So modularizing the work will help me.

---

joysn1980

2017-02-09 13:31:38 UTC

sdwdate/usr/lib/sdwdate/url_to_unixtime at master · joysn/sdwdate · GitHub

This is the first one to go. This change requires the following
sudo apt-get install python3-socksipy
sudo apt-get install python3-dateutil

---

Patrick

2017-02-09 13:36:29 UTC

! In T624#12101, @joysn1980 wrote:
Are there any other files/path involved here?

Looks complete.

There is also sdwdate
/usr/lib/python2.7/dist-packages/sdwdate/init.py
but it’s empty.

sdwdate-gui python3 port seems already done.

I do not think it is correct to take up python-guimessages here in this ticket. It is not related to sdwdate/sdwdate-gui. They should be handled separately.

Created T627 for python-guimessages.

---

Patrick

2017-02-09 13:42:00 UTC

! In T624#12127, @joysn1980 wrote:
sdwdate/usr/lib/sdwdate/url_to_unixtime at master · joysn/sdwdate · GitHub

This is the first one to go. This change requires the following
sudo apt-get install python3-socksipy

That package is not available in stretch. Currently we are using python-socks. Was possible to port from python3-socksipy to python-socks without code changes. And stretch has python3-socks. Can we use python3-socks (or another package installable from packages.debian.org)?

https://packages.debian.org/search?keywords=python3-socks

sudo apt-get install python3-dateutil

That is great. I’ll update debian/control now.

Debian -- Package Search Results -- python3-dateutil

Probably also needed: python3-gevent

Debian -- Package Search Results -- python3-gevent

---

Patrick

2017-02-09 13:43:34 UTC

update dependencies to python3
update dependencies to python3 · Kicksecure/sdwdate@c735652 · GitHub

---

joysn1980

2017-02-09 15:14:42 UTC

sdwdate/usr at master · joysn/sdwdate · GitHub

This has couple of commits involving
/usr/lib/python3/dist-packages/sdwdate/config.py
/usr/lib/python3/dist-packages/sdwdate/proxy_settings.py
/usr/lib/python3/dist-packages/sdwdate/remote_times.py
/usr/lib/python3/dist-packages/sdwdate/timesanitycheck.py
and
/usr/bin/sdwdate

First commit had few typos which I did not make. So reversing the changes in the next commit.

/usr/bin/sdwdate-gui already done by Patrick

---

joysn1980

2017-02-09 15:42:49 UTC

Probably also needed: python3-gevent

Debian -- Package Search Results -- python3-gevent

Yes, it is required by /usr/lib/python3/dist-packages/sdwdate/remote_times.py
sudo apt-get install python3-gevent worked in Whonix14 but in Whonix 13 it did not.

---

Patrick

2017-02-09 15:44:56 UTC

Merged. And added a few minor fixes on top. Please merge my changes.

Two issues found.

sdwdate does not start yet.

sudo -u sdwdate ./usr/bin/sdwdate 
Traceback (most recent call last):
  File "./usr/bin/sdwdate", line 22, in <module>
    from guimessages.translations import _translations
ImportError: No module named 'guimessages'

usr/share/sdwdate/unit_test shows some broken output:

pool 1 url znig4bc5rlwyj4mz.onion: b'%s'

---

joysn1980

2017-02-09 16:42:54 UTC

usr/share/sdwdate/unit_test shows some broken output:

porting to python3 should fix this.
Port to Python3 · joysn/sdwdate@a258198 · GitHub

    from guimessages.translations import _translations

⚓ T627 port python-guimessages to python3
port python-guimessages to python3 · joysn/python-guimessages@4929f65 · GitHub

I hope this two should fix the issues. Also, let me know if anything else needs to be done for this ticket.

---

joysn1980

2017-02-09 16:51:29 UTC

One more typo fixed
One more typo · joysn/sdwdate@27c547c · GitHub

---

Patrick

2017-02-09 18:11:56 UTC

Added some fixes on top.

Some issues.

usr/lib/sdwdate/url_to_unixtime 127.0.0.1 9050 check.torproject.org 80 true

http_time: b'Thu, 09 Feb 2017 18:00:00 GMT'

I wonder where the b is coming from. Can you remove the extraneous b?

2. There are a few type errors.

from /usr/bin/sdwdate os.environ["TEMP_DIR"] = temp_dir did not work
os.environ["TEMP_DIR"] = str(temp_dir) works for me. Is that an okay fix?

I did not manage to test yet if rmtree(pre_check.temp_dir) would work due to other issues.

3. An unresolved type error.

sudo -u sdwdate ./usr/bin/sdwdate 

sdwdate started. PID 30352
self.language is en
Tor socks host: 127.0.0.1  Tor socks port: 9050
self.language is en
Prerequisite check:
 b'Tor is not yet fully bootstrapped. Tor circuit: not established.'
Traceback (most recent call last):
  File "./usr/bin/sdwdate", line 555, in <module>
    prerequisite_check()
  File "./usr/bin/sdwdate", line 525, in prerequisite_check
    sdwdate.write_status(icon, message)
  File "./usr/bin/sdwdate", line 308, in write_status
    msgf.write(args[1])
TypeError: a bytes-like object is required, not 'str

---

Patrick

2017-02-10 01:25:08 UTC

Sorted out 2. and 3. in git master. 1. is todo.

Created T629 fix sdwdate sigterm handling during remote_times.py get_time_from_servers might be a newly introduced bug due to the newer gevent version.

---

joysn1980

2017-02-10 03:08:23 UTC

Fixed #1
Fix b in front of http_time: b'Thu, 09 Feb 2017 18:00:00 GMT' · joysn/sdwdate@e124e38 · GitHub

Tested standalone using - python3 url_to_unixtime 127.0.0.1 9050 check.torproject.org 80 true

‘b’ in front of str means it is Byte. They were ignored in Python2 but not in Python3.

---

Patrick

2017-02-10 03:24:47 UTC

Works for me! Merged.