[HOME] [DOWNLOAD] [DOCS] [BLOG] [SUPPORT] [TIPS] [ISSUES] [Priority Support]

Hardcoded template names in Qubes scripts


#1

Just stumbled on this while troubleshooting unrelated issue.

Examples:
https://github.com/QubesOS/qubes-app-linux-split-gpg/commit/ead80b1af153ee54172f21b468ce5b11cad1f63c
https://github.com/QubesOS/qubes-app-linux-split-gpg/commit/1a22a2f9d995e5544afb8cc3364554acd16f1666

These assume that Whonix templates are named whonix-gw and whonix-ws. In fact, my Whonix templates have always had custom names. Isn’t it a bad idea to hardcode template names? Would be better to use existing Whonix identification system, ie /usr/share/anon-<gw|ws>-base-files


#2

Thank you for your diligence. That looking around often leads to squashing some bugs. :slight_smile:

Yes, there are various marker files that seem better suited for that.

  • /usr/share/whonix/marker
  • /usr/share/anon-gw-base-files/gateway
  • /usr/share/anon-ws-base-files/workstation

Feel free to open a Qubes issue.
https://github.com/QubesOS/qubes-issues/issues


#3

Submitted: https://github.com/QubesOS/qubes-issues/issues/2490