enable hyperlink support in generic gui tool

[phabricator-migrator]

Information

ID: 122
PHID: PHID-TASK-3vrlcmk4wp62uihaiue7
Author: Patrick
Status at Migration Time: resolved
Priority at Migration Time: Normal

Description

Opening external links is currently unsupported. Could you take care of this please @troubadour?

This would be useful for T104.

Comments

---

troubadour

2015-01-31 15:57:35 UTC

Something that has been on my TODO list for a while.

Short: generic_gui_message does not support opening external links.

Long: the script is using Qt’s QMessageBox class, which has a restricted default behavior, not modifiable unless one rewrites it. One of the missing features is “setOpenExternalLinks”,

Possible solution: use msgdispatcher_dispatch_x (more versatile). It should be rewritten to accept other buttons than “OK”, and to be cleaned from some extra code (most of it was generated with PyQt4-Designer and translated from C++ to Python). That should not be a big deal.

The issue is to pass the result (Yes-No) to the calling bash script. It may look as trivial as print "1" or print "0", but we are in the Qt event loop… I remember trying (long) before, but there should be a solution.

---

Patrick

2015-01-31 18:35:58 UTC

That possible solution sounds good to me. Wouldn’t be a lot work for me to port from generic_gui_message to msgdispatcher_dispatch_x.

---

troubadour

2015-02-03 04:42:25 UTC

Pushed a new version of generic_gui_message. It supports opening external links,and does not require any change in the bash scripts using it.

I think it’s better to keep msg_dispatcher_x and generic_gui_message as separate scripts, even if they will share the same code once the former is rewritten. Reasons are that the arguments differ (ex: position and [whonixcheck/timesync] icon in msg_dispatcher_x only, question in generic_gui_message only), and the window size differ.

Although it is possible to merge them, we would end up with hard to read, difficult to maintain code.

---

troubadour

2015-02-03 05:24:28 UTC

Referring to T104 The warning sign is not scary enough., it’s BIG now, as well as the error sign.

No longer “No” button set as default. looking into it.

---

troubadour

2015-02-03 06:08:15 UTC

Default button is “No”.
default button "No" · troubadoour/msgcollector@b6362bf · GitHub

---

troubadour

2015-02-03 17:16:29 UTC

Pushed a commit fixing a richtext issue, but there is a big issue when opening links. Basically, generic_gui_message is calling itself, displaying the the same message. Coming back on that.

---

Patrick

2015-02-03 17:20:02 UTC

Agreed. The approach sounds good.

There is a typo:
blocquote

It doesn’t parse the rich text yet. It shows it as is. Example:

/usr/lib/msgcollector/generic_gui_message info 'Tor Browser Updater (by Whonix developers)' 'Download Confirmation
<br></br>----------------------------------------------------------------------
<pre>Currently installed version: None installed. (/home/user/tor-browser_en-US does not exist.)
Online detected version(s) : 4.5a3 4.0.3 </pre>' 'Download now?' yesno

---

troubadour

2015-02-03 17:20:34 UTC

When trying to open a link, the default browser is set to open_link_confirmation, which calls generic_gui_message.

---

Patrick

2015-02-03 17:24:25 UTC

Richtext works now, but shows an error as per git 79e4dfda022c2ee15492f1a1cc6186765cbc7ced.

/usr/lib/msgcollector/generic_gui_message info 'Tor Browser Updater (by Whonix developers)' 'Download Confirmation
<br></br>----------------------------------------------------------------------
<pre>Currently installed version: None installed. (/home/user/tor-browser_en-US does not exist.)
Online detected version(s) : 4.5a3 4.0.3 </pre>' 'Download now?' yesno
Traceback (most recent call last):
  File "/usr/lib/msgcollector/generic_gui_message", line 95, in setSize
    messageHeight = self.text.document().size().height()
AttributeError: 'QLabel' object has no attribute 'document'
6553

---

troubadour

2015-02-03 20:39:46 UTC

Fixed. Something weird here. There was a bug, and I could not spot it in the normal course of the TBB installation, all looking normal (with Install now?though). Nevermind.

Another small issue. In update-torbrowser, when the signature verification fails, it looks like the message is going to msgdispatcher.

      local MSG="<p><b>GPG download signature could NOT be verified.</b>
<br></br>Tor Browser update failed! Try again later.</p>"
      $output ${output_opts[@]} --progressbaridx "$progressbaridx" --progressx "100" || true

      $output ${output_opts[@]} --messagex --typex "error" --message "$MSG" --done
      $output ${output_opts[@]} --messagecli --typecli "error" --message "$MSG" --done
      exit 1
   fi

Would it not make sense to pop a generic gui, with a big red icon?

---

Patrick

2015-02-03 23:30:14 UTC

Yes, that one is fixed.

Issues:

• cannot copy from the window
• no scrollbar if too much vertical text
• no scrollbar if too much horizontal text
• text gets truncated without scrollbar, i.e. when you run

/usr/lib/msgcollector/generic_gui_message info 'Tor Browser Updater (by Whonix developers)' 'Download Confirmation
<br></br>----------------------------------------------------------------------
<pre>Currently installed version: None installed. (/home/user/tor-browser_en-US does not exist.)
Online detected version(s) : 4.5a3 4.0.3 </pre>' 'Download now?' yesno

You can only see Currently installed version: None installed. (/home/user/t.

Would it not make sense to pop a generic gui, with a big red icon?

Dunno. I would prefer to not overuse the big one. That error message is “not that important”. I mean, the signature confirmation users could result in a downgrade attack. But that “it failed, nothing too bad happened one”, users will notice sooner or later, try again etc.

---

troubadour

2015-02-04 20:46:39 UTC

Everything should be back to normal. There was strange combination of circumstances: the HTML in update-torbrowser was not right AND the examples above are wrong too. Need double quotes to pass parameters to python from the shell and <pre> is not recognized, apparently.

For testing:

The text copy is fixed in the last commit in msgcollector and the HTML in fix HTML · troubadoour/tb-updater@2582f6c · GitHub (done it twice because you updated tb-updater a few hours ago :).

---

Patrick

2015-02-04 21:29:07 UTC

Merged.

Do you have a test command that isn’t in one line?

Caused a regression that has a separate ticket: T123

---

Patrick

2015-02-06 18:18:15 UTC

Two issues:

• The “no” button is not is not visibly selected by default. (“Yes” is not the default either, but the “no” button has no blue surrounding.) Using arrow keys is not possible. I think none of the buttons is selected by default.
• The window is not centered for some reason.

Example test command (for copy and paste):

/usr/lib/msgcollector/generic_gui_message warning 'Tor Browser Updater (by Whonix developers)' '<p>Download Confirmation<br></br>
----------------------------------------------------------------------</p><p><table><tr>
<td>Currently installed version:</td> <td><tt>4.0.3</tt></td></tr><tr>
<td>Online detected version(s) :</td> <td><tt>4.5a3 4.0.3 </tt></td></tr></table></p>

<p>Looks like there is an upgrade for Tor Browser.</p>

<p>Please close Tor Browser if you want to (re-)install!</p>

<p>If your currently installed version is:<blockquote>
   - higher: you are likely target of a downgrade attack, SAY NO NOW.<br></br>
   - equal : only proceed, if you want to create a new browser profile.<br></br>
   - lower : you should upgrade.</blockquote></p>

<p>YOUR BROWSER WILL BE KILLED.<br></br>
YOUR WHOLE BROWSER PROFILE INCLUDING BOOKMARKS AND PASSWORDS WILL GET REPLACED.</p>

<p>A backup of your old Tor Browser and settings will be created in your home folder.
<br></br>It is a good idea to delete old TBB backups once in a while if you are running low with disk space.</p>' 'Download now?' yesno

---

troubadour

2015-02-07 19:33:10 UTC

There was a couple of issues, the main one not being able to properly set the “no” button to default with QT “StandardButtons” (I’ll pass the details) . So it was rewritten with push buttons, looking identical.

Other changes :

• width increased to 600. Looks better in some situations.
• fixed size window (no maximize button). Had to do it because of the fixed position of the buttons when resizing the window. Now it behaves like a standard message box (with some extras).

The window is centered when called from the scripts. For an unknown reason, it moves down when called from a terminal.

use QPushButton instead of StandardButton ot be able ot set "No" butt… · troubadoour/msgcollector@9ced203 · GitHub

---

Patrick

2015-02-07 19:49:31 UTC

Merged. Looks good so far.

Two issues:

• moved down also when called from script
• hyperlinks can not be clicked / opened

---

Patrick

2015-02-07 19:51:06 UTC

Another issue:

• selecting text works, but right click menu is disabled / no copy/paste possible

---

Patrick

2015-02-07 19:52:05 UTC

Another issue:

• When moved down (also when called from script), the buttons are outside the visible space. One would need to move the window up first to see the buttons.

---

troubadour

2015-02-08 15:29:20 UTC

back to StandardButtons, window sizeable · troubadoour/msgcollector@54b0943 · GitHub should fix it all (amazing how a task that was looking like a piece of cake can become a burden when you take for granting that it works, without proper testing…).

• open external links working.
• select and copy text working.
• vertical scroll bar as needed.
• “No” button set as default on opening, highlighted with blue border.
• window properly centered on screen.
• window resizeable (maximize button too).

---

Patrick

2015-02-08 15:40:02 UTC

All tested. All works nice! Merged.