do not run rads outside of boot process

[phabricator-migrator]

Information

ID: 308
PHID: PHID-TASK-fe4dqmg4bfdm4f2ox5ua
Author: Patrick
Status at Migration Time: resolved
Priority at Migration Time: Normal

Description

There is a bug. When installing/updating rads when no login manager is started, rads is started. Example: when running no login manager and running “apt-get dist-upgrade” during a rads upgrade.

Half solution: make rads exit early if stdin and/or a tty is detected. (When run by systemd during boot, there is no stdin connected.)

Full Solution: somehow distinguish “boot → run rads normally” vs “run by apt-get/dpkg → exit rads early”.

Comments

---

Patrick

2015-05-18 12:38:19 UTC

Implemented the half solution.
Do not run rads outside of boot process.
When started by systemd, there is no stdin connected and "tty" exit code is 1.
In these cases, rads is likely run during an interactive apt-get upgrade.
Exit in those cases.
https://phabricator.whonix.org/T308:
Do not run rads outside of boot process. · Kicksecure/rads@d3c27f7 · GitHub

---

Patrick

2015-05-18 13:15:16 UTC

How to distinguish if a systemd unit is run by apt-get or during boot?:
How to distinguish if a systemd unit is run by apt-get or during boot? - Unix & Linux Stack Exchange

---

Patrick

2015-05-20 22:42:56 UTC

How to distinguish if a systemd unit is run by apt-get or during boot?:
How to distinguish if a systemd unit is run by apt-get or during boot?

---

Patrick

2015-05-23 00:19:08 UTC

do not run rads outside of boot process - https://phabricator.whonix.org/T308:
do not run rads outside of boot process - https://phabricator.whonix.… · Kicksecure/rads@cb90ac1 · GitHub

---

Patrick

2015-05-23 15:53:57 UTC

! In T308#4679, @Patrick wrote:
Implemented the half solution.
Do not run rads outside of boot process.
When started by systemd, there is no stdin connected and "tty" exit code is 1.
In these cases, rads is likely run during an interactive apt-get upgrade.
Exit in those cases.
https://phabricator.whonix.org/T308:
Do not run rads outside of boot process. · Kicksecure/rads@d3c27f7 · GitHub

Undone because of better implementation (https://phabricator.whonix.org/T57#4891) and because dh_systemd_start --no-start (https://phabricator.whonix.org/T308#4837) is enough.

---

Patrick

2015-05-24 15:18:03 UTC

Fixed in Whonix 11.0.0.2.0-developers-only.

Running sudo apt-get install --reinstall rads and sudo apt-get purge rads && sudo apt-get install rads succeeded (didn’t start rads during re-installation). (Currently from developers repository that was upgraded as per 11.0.0.2.0-developers-only.)