Disable VLC metadata collection by default

[phabricator-migrator]

Information

ID: 736
PHID: PHID-TASK-imdahpahgeuo5zmcz5kn
Author: TNTBOMBOM
Status at Migration Time: resolved
Priority at Migration Time: Normal

Description

This is for user safety , to avoid pressing on continue and he wasn’t aware of what it does say.

{F2399084}

TODO:

• /etc/vlc.d configuration snippet drop-in feature request
• Meanwhile should be implemented minimal VLC config preconfiguring this in #anon-apps-config /etc/skel.

Comments

---

Tibo

2018-04-07 16:41:13 UTC

Withc VLC a config file is created per user and there is no global configuration.
The path is $HOME/.config/vlc/vlcrc.

As far as I understand, the content of /etc/skel/ is magically being copied in the user directory.
So I modified the architecture as follow :

etc
|-- skel
|   `-- .config
|       `-- vlc
|           `-- vlcrc

I tested it, and it works, what do you think ?
Should I fork the anon-apps-config repo on github, and make a pull request ?{F6896915}

---

Patrick

2018-04-09 04:00:42 UTC

Looks good!

Should I fork the anon-apps-config repo on github,

Yes.

and make a pull request ?

• Pull request is one accepted way.
• Another accepted way is just posting to any branch and posting the branch name here.
• Currently it’s even accepted to to commit to you fork’s master branch and then I’ll merge that as well. (However, in case we’d ever reach a dead-end you’d have to reset your master branch.)
• Other suggestions?

Please pick the most comfortable one.

---

Tibo

2018-04-09 05:21:09 UTC

I’m fine a with a pull request !
Do you have other tasks for me ?

I have just a simple question, how do you know if somebody is not already working on a task ?

---

Patrick

2018-04-09 11:16:41 UTC

! In T736#15889, @Tibo wrote:
I have just a simple question, how do you know if somebody is not already working on a task ?

If it is assigned to someone on phabricator like now. (Or by the context of the discussion but we should assign tasks.)

---

Patrick

2018-04-09 11:19:17 UTC

! In T736#15889, @Tibo wrote:
Do you have other tasks for me ?

Easy, testing only:
T444

Easy, testing only:
T652

Qubes specific, testing should be easy but if it’s broken maybe not easy to fix:
T781

---

Patrick

2018-04-09 12:30:54 UTC

T772 has stalled as well.

---

Patrick

2018-04-09 16:22:07 UTC

disable ntp time check by TNTBOMBOM · Pull Request #1 · Whonix/anon-apps-config · GitHub

---

Patrick

2018-04-09 16:25:39 UTC

qt-privacy-ask=0

By name only means “do not ask”.

Stop VLC.
Delete VLC config.
Start with your config.

Does the metadata collection show up as disabled in VLC settings?

If yes, this is ready to merge. Even easy enough for #Whonix_14.

---

Patrick

2018-04-09 16:27:15 UTC

Answering the meta questions here for me was not so clever this it created these references. Not a big deal either. However, better to have a development forum thread.

Mentioned Here
T772: Managing programs without Tor DNS Support
T444: Ricochet IM
T652: anon-gpg-tweaks Debian stretch changes required
T781: tb-updater do not populate home directory at first boot?

---

Tibo

2018-04-09 17:46:37 UTC

Hi !

The name is confusing I agree.
But it actually does disallow metadata network access.

| qt-privacy-ask=0 | qt-privacy-ask=1 |
| No pop-up asking for allowing metadata |The pop-up is showing and asking for metadata collection |
| Correctly disable in VLC settings | Either have to check it or not (If you close the popup it also disallow metadata collection) |
|{F7027941}|{F7027955}|

---

Patrick

2018-04-11 10:46:41 UTC

Merged.

[nurmagoz]

What happened to this ticket, at the moment VLC does show the collecting page similar to before.

[Patrick]

I cannot reproduce this. Works for me as expected. No metadata related question by VLC at startup inside Whonix-Workstation.

This is a feature of package GitHub - Whonix/anon-apps-config. Implemented in the following configuration file:

etc/skel/.config/vlc/vlcrc

Therefore this feature is unfortunately not applicable to Kicksecure because anon-apps-config is not designed for Kicksecure compatibly.

So if this issue was produced in Kicksecure, not Whonix, then this is the reason.