common code paths make sense for non-Qubes and Qubes (if any of these are changed) so upstream is comfortable to merge them
Otherwise Qubes specific code paths stay out of the way for non-Qubes.
I need a trusted C code reviewer. Reviewing at least for non-maliciousness. Functionality testing we have testers here.
Hopefully upstream could review the Qubes specific code paths for non-maliciousness and then trust Whonix contributors to test functionality in Qubes. (I don’t have any indications that upstream is using Qubes and that’s a big ask.)
Unfortunately quote common that projects from academic backgrounds are unmaintained in the long run. General huge issue of code getting deprecated after a while in Open Source due to lack of contributors and non-existent business model.
A different approach would be for you to independently fork kloak and then get it merged into Tails or even better packages.debian.org. Maybe it doesn’t need to come to that. Let’s see how active upstream now is.
A wholly different idea: Any reason this must be written in C? Could this be rewritten in python or something?
Not sure if you have access to chatgpt4 (version 4). But if you have, could you run it through chatgpt4 please to see if it can find (and even fix) some more code issues (in upstream dev branch or your branch)?