control-port-filter-python improved debug output

Phabricator Tickets
1

Information

ID: 222
PHID: PHID-TASK-dt5kpzrojzfhojtkmafv
Author: Patrick
Status at Migration Time: resolved
Priority at Migration Time: Normal

Description

To help with T218, I thought it would help to have improved debug/log output.

To avoid merge conflicts, I didn’t know if you are doing any bigger changes at this moment, I have created a branch instead of committing to master:

Just one commit for now:

It would have been difficult to translate those all into speech / tickets. Code talks more.

  • Moved the logging commands around. Wanted to make sure we learn as early as possible about connection contents and and what is being replied in all cases.
  • Log lying instead of just doing it.
  • minor: removed extraneous for more consistent logs
  • minor: comment
  • T221

Please merge this branch, and if there are merge conflicts or mistakes, please just manually (re-) implement if applicable.

Comments

Patrick

2015-03-06 17:25:33 UTC