Bug report, module tirdad fails to load

arraybolt3 · June 23, 2026, 4:23am

Bug reported to Tirdad upstream:

Fails to load with kernel 6.12.94

opened 04:20AM - 23 Jun 26 UTC

Linux seems to have backported the new API for ISNs and TCP timestamps into stab…le kernel 6.12.94: https://www.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.12.94 ``` commit 5da5662181ef8a251e3ba564903002c2e87de452 Author: Eric Dumazet <edumazet@google.com> Date: Tue Jun 16 14:36:29 2026 +0200 tcp: secure_seq: add back ports to TS offset [ Upstream commit 165573e41f2f66ef98940cf65f838b2cb575d9d1 ] This reverts 28ee1b746f49 ("secure_seq: downgrade to per-host timestamp offsets") tcp_tw_recycle went away in 2017. Zhouyan Deng reported off-path TCP source port leakage via SYN cookie side-channel that can be fixed in multiple ways. One of them is to bring back TCP ports in TS offset randomization. As a bonus, we perform a single siphash() computation to provide both an ISN and a TS offset. Fixes: 28ee1b746f49 ("secure_seq: downgrade to per-host timestamp offsets") Reported-by: Zhouyan Deng <dengzhouyan_nwpu@163.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com> Acked-by: Florian Westphal <fw@strlen.de> Link: https://patch.msgid.link/20260302205527.1982836-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> (cherry picked from commit 165573e41f2f66ef98940cf65f838b2cb575d9d1) [kept the DCCP functions in the header, as DCCP was not retired yet in 6.12] Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> ``` As a result, tirdad [fails to load on this and newer* 6.12.x kernels.](https://forums.whonix.org/t/bug-report-module-tirdad-fails-to-load/23302) The following patch works to solve this for me, it simply marks the rest of the 6.12.x line starting with version 6.12.94 as needing the new API: ``` diff --git a/module/tirdad.c b/module/tirdad.c index 7b9c856..ea6c139 100644 --- a/module/tirdad.c +++ b/module/tirdad.c @@ -44,7 +44,8 @@ void _s_out(u8 err, char *fmt, ...){ va_end(argp); } -#if LINUX_VERSION_CODE < KERNEL_VERSION(6, 18, 17) +#if LINUX_VERSION_CODE < KERNEL_VERSION(6, 12, 94) \ + || (LINUX_VERSION_CODE >= KERNEL_VERSION(6, 13, 0) && LINUX_VERSION_CODE < KERNEL_VERSION(6, 18, 17)) u32 secure_tcp_seq_hooked(__be32 , __be32 , __be16 , __be16 ); u32 secure_tcpv6_seq_hooked(const __be32 *, const __be32 *,__be16 , __be16 ); ``` <sup>*well, there aren't any newer 6.12.x kernels at the moment, but there probably will be.</sup>

Fix created, I tested this locally and it works: