break when attempting to build from non-tagged git by default

Information

ID: 231
PHID: PHID-TASK-cpn7rbjcjjcygkqgn63c
Author: Patrick
Status at Migration Time: resolved
Priority at Migration Time: Normal

Description

Some support requests are generated because users do not check out a tag, i.e. effectively build from master. This sometimes causes difficult support requests.

A sanity test could be easily implemented.

--allow-untagged false|true
false: Break when build from non-tag. Default.
true: Do not use unless you know what you are doing.

In essence by comparing the output of

git describe --always --abbrev=0
9.6

vs

git describe --always --abbrev=1000000000
10.0.0.3.7-developers-only-6-g505c39d44d2a08451f7ff53ce67d78745e05816b

Similar to function check_for_uncommited_changes with a good error message that suggests to just add --allow-untagged true for developers / advanced users.

Comments


Patrick

2015-03-13 17:46:15 UTC