On the second thought we should be careful with this. If not absolutely
required for Whonix 14, leaving it out. This could introduce some unique
bugs.
First of all, we have to see what upstream thinks about this and how
they go about fixing it. Then if possible and needed, we can add their
fix in Whonix earlier than their fix flows down to Whonix.
By the way, I think it would be unreasonable to ask you to do github
pull requests. Not asking for that from anyone else currently either.
Usually it should be enough if you do the git commits. Then I just git
fetch your repository and merge.
Otherwise the more formal approach for third party projects is to create
a new branch based on the source branch (mostly master, some call it
stable or something else), and then create a pull request. Since we’re
familiar here, we can skip such formalities to save time.
On the other hand, github pull requests leave a nice history on github.
So it’s up to you.
(Maybe if we introduce a Whonix14 branch or so or call master only for
Whonix14 or something… Then it may be reasonable to work with
branches. But for now we can keep it simple.)
Sounds good to me. Feel free to do the git pull irykoon master if it is more convenient for you.
Sometimes, I need to inform you I did some commits on a repository anyway, so in some cases, I may still use a pull request as a notification that is harder to be missed in the future.
No worry about this. The nice history will neither increase nor decrease my contributions to Whonix.
The way tor_status.py check DisableNetwork and enable/disable Tor is out of date:
The better way to do this is using Tor controller:
Since this will be an almost complete rewrite of tor_status.py, I will think more about this and implement and test it with cautious.
Current thought:
If Tor process is not enabled, do systemctl --no-pager restart tor@default (In Whonix, Tor process should always be up and the only difference is connected to the Tor network or not. Correct?)
Enable/Disable Tor through Tor control port
Control if Tor will auto connecting to the Tor network at next boot by writing DisbaleNetwork 1 in the files.
I guess we should pop up anon-connection-wizard at boot time as long as Tor is not connecting to the Tor network? (This is not the case currently, btw. And yes, I will fix it if it is not the expected behavious. )