Xfce theming - a few suggestions

Great, will do.

It is hard to see the separators of the workspace switcher with arc theme.

@Patrick

I created two new files on GitHub regarding download/install of Arc icons and theme (just basic instructions, must be integrated into Whonix build code):

And two pull requests in order to update these changes in etc/skel/.config/xfce4/xfconf/xfce-perchannel-xml/xsettings.xml and etc/skel/.config/xfce4/xfconf/xfce-perchannel-xml/xfwm4.xml files:

Also, for some reason I don’t see the pulseaudio plugin in the panel by default (using latest 15.0.0.0.3.3), ist normal? (should be default as per latest commit: xfce-desktop-config-dist/xfce4-panel.xml at master · Kicksecure/xfce-desktop-config-dist · GitHub)

3 Likes

Is using files from outside of Debian somehow avoidable? Can we pretty please only use stuff which already comes from packages.debian.org?

(Background: security, difficulty to make this work in build scripts on all platforms in all network configurations, signature verification, licensing, theoretically potentially malicious icons specifically crafted only for Whonix, Whonix Default Application Policy )

Added.

https://github.com/Whonix/whonix-xfce-desktop-config/commit/86ea58a935b2932b06dcb63368d5439304937986

https://github.com/Whonix/whonix-xfce-desktop-config/pull/6

Merged.

Saw only one pull request with two commits but I guess that is ok.

Whonix 15.0.0.0.3.3 points at whonix-xfce-desktop-config 2.0-1 which does not have that change yet.

1 Like

I understand the concern. Unfortunately, I haven’t found this icon theme in official Debian packages. Up to you to include it or not.

Correct, that’s what I meant :slight_smile:

All clear

1 Like

Can we use any other suitable icons / theme / whatsoever available form
packages.debian.org?

1 Like

Here is the list of all “icon-theme” packages in Debian:
https://packages.debian.org/search?keywords=icon-theme
Personally, I don’t like most of them.
If I had to choose, I would just use the default gnome theme (already installed) or Adwaita. I just dislike the current default one - Gnome Brave - which looks childish to me.

2 Likes
1 Like

We still need to pick the best one from there.

What about Debian -- Details of package elementary-xfce-icon-theme in buster? elementary is a usability and beauty focused distribution. The package seems available Free and unencumbered with whatever (great not great - i never looked into it, just heard positive about it) do. So seems perfect fit.

Personnaly I prefer the stock Adwaita icons :slight_smile:

Tested. Actually does not look great with our dark XFCE theme.

Alright, therefore no more changes needed as far as I know.

A post was split to a new topic: Fork XFCE Theming of another Debian based Linux distribution

Thank you @Patrick et al. for implementing Arc theme and Adwaita icons into the latest Whonix 15 OVA. The Buster Adwaita stock icons are way better than Stretch (e.g. folder icon in Thunar), I’m so happy, and I now consider things fully fixed in this department!

1 Like

Something left to do here?

Suggestion: place the panel on top (ALL flavors)
Reasoning: at least with virt-manager, you usually don’t put the VMs in full-screen in order to easily switch between different VMs and/or Host programs.

With the current settings you end up with something like this:

i.e. you never see the panel (hidden below) and you have to enable full-screen again to do anything useful inside the VM.

With the panel placed on top, you can still access it and manage your opened applications in the VM without having the need to enable full-screen, while still keeping quick access to your Host applications:

Much more practical! Also looks better and more functional IMHO. Top panel is actually default behavior for many XFCE distros (debian with XFCE, Xubuntu…).

1 Like

Unless someone has an excellent argument against this…

Yes, please go for it.

Done.

Not sure whether this change will apply to all flavors? Is there only one panel xml file for all flavors or separate ones for each of them?

1 Like

Merged. :slight_smile:

In this very case for this very file it will apply to all flavors.


In another case for xfce4-desktop.xml it is specific for host / gateway / workstation.


If needed, more files can be added there.

(Yeah, implementation is a bit weird but XFCE is a bit limited on how this could be designed.)

Nothing left to do here?

desktop backgrounds broken in Whonix KVM:

Most likely a KVM specific bug.

desktop background files in the git repository:

These files will end up in user’s home folder at first boot:

/home/user/.config/xfce4/xfconf/xfce-perchannel-xml/xfce4-desktop.xml

File will be modified by Xfce.

Note:
Files in /etc/skel

Possible the following setting…

    <property name="screen0" type="empty">

Works in VirtualBox but not in KVM.

Testing modified files in /etc/skel is cumbersome. I wrote a script which is supposed to be run from a virtual console to simplify the steps:
/usr/libexec/helper-scripts/desktop-background-skel-test

1 Like