Looks good overall!
It’s OK because it’s highly unlikely to break anything existing.
Seems pretty perfect.
Some nitpicks:
- What would happen with file https://github.com/Whonix/Whonix/blob/master/build-steps.d/2375_build_rpi_fs?
- (Whonix for arm64 / Raspberry Pi ( RPi ) - duplicate forum topic)
- Would be removed? Not a big deal since RPi support is currently broken anyhow with nobody working on it.
- Some
$variables should be quoted.
cp $binary_image_raw $orig_img
mkdir --parents $mpoint_efi
rm $orig_img
Few more.
Not a big deal. I could add the nitpick on top (but then hope the quoting doesn’t break it although very unlikely).
Optional, non-blocker:
That would be Whonix for macOS: Download and Installation?
That would be
- Build and Update Whonix from Source Code
- Build Configuration - Whonix
- Template:Build Documentation 64bit - Whonix (not best URL, should perhaps move tempalte)
(Please disagree should I suggest some wrong stuff. I am certainly not married to any of these opinions. :))