apparmor-profile-whonixcheck:
Added full read access on /etc/tor folder. Not an important change, but useful in future and more robust. This is needed for whonxicheck to see if Tor has been enabled in torrc (DisableNetwork 0). It already works, but only implicitly, because apparmor-profile-anondist allows access to /etc/tor/tor.anodist. When someone uses symlinks to torrc (for example tor-launcher adds a symlink /etc/tor/torrc.orig1 â /etc/tor/torrc) then it would break. Therefore given full read access. Please review. https://github.com/Whonix/apparmor-profile-whonixcheck/commit/df62d410ee9f0781ac3a465481d65bdd7581e397
This is something weâll have to clarify. When Tor Browser is confined, it does not honor the Preferences âAlways ask me where to save filesâ option, which is the default setting. It tries to save the file in âTorBrowserPath/tor-browser_en-US/Browser/Downloadsâ, a directory that does not exist after installation.
@parick
To circumvent the problem, may be we should create a /home/user/tor-browser_en-US/Browser/Downloads" directory, as well as the â/home/user/Downloadsâ. The user could set the preferences later,
Micah Lee is doing that, in â~/.local/share/torbrowser/tbb/x86_64/tor-browser_en-US/Browser/Downloadsâ, which does not help finding the downloads . The access to @HOME is forbidden. That has been the main discussion point about usability I had in torbrowser-launcher issues on github.
OK. This a new entry in the profile. In case only the path or the mask is changing, can you leave the old lines untouched and add new lines, for compatibility with older versions?. The cleanup can be done whenever we feel itâs safe.
[quote=âtroubadour, post:469, topic:108â][quote author=Patrick link=topic=97.msg5527#msg5527 date=1416021015]
Minor changes, because sdwdate has been refactored:
OK. This a new entry in the profile. In case only the path or the mask is changing, can you leave the old lines untouched and add new lines, for compatibility with older versions?. The cleanup can be done whenever we feel itâs safe.[/quote]
+1
What would be a good storage location / path to be compatible with Whonixâs apparmor-profile-torbrowser profile?
We could just add any path to suite us⌠ButâŚ
Keeping compatibility with torbrowser-launcher in mind for the future⌠So ideally it would be compatible with torbrowser-launcherâs Tor Browser AppArmor profile as well. Can you think off any path we might convince them to add for this use case? Ideally not adding âwhonixâ within the path name. Some thing likeâŚ
/usr/share/homepage r,
/usr/share/homepage/** r,
How does that sound? Then we we put the local Whonix homepage into /usr/share/homepage/whonix and others are free to use /usr/share/homepage/tails and so forth?
What would be a good storage location / path to be compatible with Whonixâs apparmor-profile-torbrowser profile?
We could just add any path to suite us⌠ButâŚ
Keeping compatibility with torbrowser-launcher in mind for the future⌠So ideally it would be compatible with torbrowser-launcherâs Tor Browser AppArmor profile as well. Can you think off any path we might convince them to add for this use case? Ideally not adding âwhonixâ within the path name. Some thing likeâŚ
/usr/share/homepage r,
/usr/share/homepage/** r,
How does that sound? Then we we put the local Whonix homepage into /usr/share/homepage/whonix and others are free to use /usr/share/homepage/tails and so forth?[/quote]
That sounds good. It is an obvious place where to put the homepage. I will make the addition to the profile.
What sounds good too is to have a Whonix homepage. Whatever the look, it will be better than a blank page.
Still, /usr/share/homepage seems the best candidate. I do not know if Micah is maintaining the profiles in torbrowser-launcher. Intrigeri has made some pull requests earlier, with major updates. Should we open a ticket in torbrowser-launcher github issues now? I am not sure how we should phrase it.
Yes. Letâs phrase it together. I am a big fan of phrasing things together. Much better chance of being clear, understood and succeeding.
I guess a pull request adding these two lines would do.
Donât remember⌠If youâre uncomfortable with git branches and pull requests, would you be comfortable using githubâs internal editor? (Or I do it. Nevermind. Either way.)
Here is my proposal. (Using github markup already.) Please feel free to either post it right away, either after adjusting it or not, or going through another round of discussion if you feel thatâs useful.
What do you think about adding a read-only AppArmor permission to the /usr/share/homepage folder?
(@Whonix is probably soon getting a [local homepage](Whonix Forum. And we would like to store our local homepage at /usr/share/homepage/whonix-homepage.)
The distribution agnostic path name /usr/share/homepage should allow any distribution or derivative allow dropping their homepage folder there.
Can you please check if this approach is sane, review and merge?
A bit of history. When I tested torbrowser-launcher for the first time in jessie, it was not working with AppArmor. I did check the profiles, there were some path issues firstly. I had to modify all four profiles in order to get it working happily when confined. I opened a ticket on github and Micah merged my profiles. apparmor modifications ¡ Issue #119 ¡ micahflee/torbrowser-launcher ¡ GitHub
I believe that for such a small change, we have a fair chance that it will be accepted right away. I will fork torbrowser.Browser.firefox, make the changes and post the request on github.
What do you think about adding a read-only AppArmor permission to the /usr/share/homepage folder?
(@Whonix is probably soon getting a [local homepage](Whonix Forum. And we would like to store our local homepage at /usr/share/homepage/whonix-homepage.)
The distribution agnostic path name /usr/share/homepage should allow any distribution or derivative allow dropping their homepage folder there.
Can you please check if this approach is sane, review and merge commit 12402ae7 ?