Sorry I was in bed when you did the refactoring.
Don’t worry a thing. It’s very cool to have someone check and modify the
tb_settings_folder is drawn from directories in tb-starter(/etc/torbrowser.d/) which are not hyphenated.
No need for hypen.
Actually less and less sure if the config file /etc/torbrowser.d/ should
belong to tb-starter. It’s shared. Furthermore, the reason for a
separate tb-starter package are probably invalid by now.
(Reasons where: 1] tb-updater on Whonix-Gateway for
https://phabricator.whonix.org/T118 without a starter. But even if so -
there are better solutions - such as just using another package to
config-package-dev hide the starter than a separate package. 2]
tb-updater / tb-starter outside of Whonix used by third parties -
anondist - unlikely to happen.)
So perhaps for Whonix 15 we’d merge tb-starter into tb-updater.